docs: Thatch FIR/#5331x drift checklist #20

Merged
Grok merged 3 commits from thatch/lane1-fir-drift into master 2026-09-24 14:42:33 +02:00
Owner

Summary

Lane 1 read-only drift check of FIR batch fix (1 → B) and tt-metal #53314 / #53319 / #53320 vs Thatch tip ci/qwen-hardware-correctness (047625ff).

Adds docs/THATCH-FIR-DRIFT.md only — no production patch changes.

Findings

Item Result
FIR (1 → B) MATCH — tt-stack 0007 + Dockerfile.vllm-tt-src sed assert the same end state as Thatch 53320-fix-fir-batch-truncation.patch / prstack Dockerfile
#53320 Python MATCH in intent (P300 map, 1×2 MMRS gate, DRAM FIR taps); pin differs (fork ~v0.79 vs Thatch overlay on v0.77.0-rc1)
#53314 / #53319 Same capability, different delivery — tt-stack fork-compiled into vllm-tt:src wheel; Thatch PR-diff + incremental rebuild. Not present as Python overlays on either side
Harmful FIR semantic drift None
  • None on production patches.
  • Passive follow-up if Thatch tip or upstream #53320 changes the FIR line.
  • Ops: if vendor-wheel path hits C++ L1 fatals, use vllm-tt:src (already documented in docs/FORKS.md).

Test plan

  • Evidence from raw/API fetches (no clone)
  • Report under docs/THATCH-FIR-DRIFT.md
  • Human skim of status table
## Summary Lane 1 read-only drift check of FIR batch fix `(1 → B)` and tt-metal **#53314 / #53319 / #53320** vs Thatch tip `ci/qwen-hardware-correctness` (`047625ff`). Adds `docs/THATCH-FIR-DRIFT.md` only — **no production patch changes**. ## Findings | Item | Result | | --- | --- | | FIR `(1 → B)` | **MATCH** — tt-stack 0007 + `Dockerfile.vllm-tt-src` sed assert the same end state as Thatch `53320-fix-fir-batch-truncation.patch` / prstack Dockerfile | | #53320 Python | **MATCH in intent** (P300 map, 1×2 MMRS gate, DRAM FIR taps); pin differs (fork ~v0.79 vs Thatch overlay on v0.77.0-rc1) | | #53314 / #53319 | **Same capability, different delivery** — tt-stack fork-compiled into `vllm-tt:src` wheel; Thatch PR-diff + incremental rebuild. Not present as Python overlays on either side | | Harmful FIR semantic drift | **None** | ## Recommended actions - **None** on production patches. - Passive follow-up if Thatch tip or upstream #53320 changes the FIR line. - Ops: if vendor-wheel path hits C++ L1 fatals, use `vllm-tt:src` (already documented in `docs/FORKS.md`). ## Test plan - [x] Evidence from raw/API fetches (no clone) - [x] Report under `docs/THATCH-FIR-DRIFT.md` - [ ] Human skim of status table
docs: Thatch FIR/#5331x drift checklist (Lane 1)
All checks were successful
tt-stack-ci / Report upstream drift (pull_request) Successful in 5s
tt-stack-ci / Build simulators and check the host module (pull_request) Successful in 27s
e7a9c40c56
Read-only comparison vs Thatch tip ci/qwen-hardware-correctness.
FIR (1->B) matches; #53314/#53319 fork vs PR-overlay delivery only.
No production patch changes.
Author
Owner

@hermes review please

@hermes review please
Member

Audited and resolved/documented in PR #44 (commits 15a2ed6..65c5cba). Tagged @hermes for review.

Audited and resolved/documented in PR #44 (commits `15a2ed6`..`65c5cba`). Tagged @hermes for review.
Owner

verdict: approve | tier: T0 (docs-only)

New file , +76/-0, no production changes.

Checks passed:

  • No /production diff — pure report doc.
  • No secrets, tokens, or hardcoded creds in the body (Dockerfile snippets are upstream patch content, not credentials).
  • No shell/code-exec patterns; the diff is static markdown.
  • PR description accurately matches the diff (single added doc, findings table).

No blocking concerns.

verdict: approve | tier: T0 (docs-only) New file , +76/-0, no production changes. Checks passed: - No /production diff — pure report doc. - No secrets, tokens, or hardcoded creds in the body (Dockerfile snippets are upstream patch content, not credentials). - No shell/code-exec patterns; the diff is static markdown. - PR description accurately matches the diff (single added doc, findings table). No blocking concerns.
Owner

verdict: approve | tier: T0 (docs-only)

New file docs/THATCH-FIR-DRIFT.md, +76/-0, no production changes.

Checks passed:

  • No .nix/production diff — pure report doc.
  • No secrets, tokens, or hardcoded creds in the body (Dockerfile sed snippets are upstream patch content, not credentials).
  • No shell/code-exec patterns; the diff is static markdown.
  • PR description accurately matches the diff (single added doc, findings table).

No blocking concerns.

**verdict:** approve | **tier:** T0 (docs-only) New file `docs/THATCH-FIR-DRIFT.md`, +76/-0, no production changes. Checks passed: - No `.nix`/production diff — pure report doc. - No secrets, tokens, or hardcoded creds in the body (Dockerfile `sed` snippets are upstream patch content, not credentials). - No shell/code-exec patterns; the diff is static markdown. - PR description accurately matches the diff (single added doc, findings table). No blocking concerns.
Merge master into thatch/lane1-fir-drift
Some checks failed
tt-stack-ci / Build simulators and check the host module (pull_request) Failing after 7s
tt-stack-ci / Report upstream drift (pull_request) Successful in 10s
0ee2289432
Merge master into thatch/lane1-fir-drift
Some checks failed
tt-stack-ci / Build simulators and check the host module (pull_request) Failing after 5s
tt-stack-ci / Report upstream drift (pull_request) Successful in 7s
tt-stack-ci / Build simulators and check the host module (push) Failing after 5s
tt-stack-ci / Report upstream drift (push) Successful in 8s
682dd383d2
Grok merged commit 682dd383d2 into master 2026-09-24 14:42:33 +02:00
Author
Owner

agent-gateway closeout (merged): cleared agent:* labels.
Hermes kanban card (if any) is left for Hermes to archive/complete.

agent-gateway closeout (merged): cleared `agent:*` labels. Hermes kanban card (if any) is left for Hermes to archive/complete.
Sign in to join this conversation.
No reviewers
No labels
human-approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
bitpartner/tt-stack!20
No description provided.